Two more little patches for md (sorry for the dribs-and-drabs).

Feel free to leave them until post-2.6.11, though the first is really trivial
and allows md/multipath arrays be assembled (without it they just won't work).

- Fix typo for multipat assembly with will
- Mark raid6 non-experimental and tidy up bits of Kconfig

NeilBrown

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo [at] vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

In md, there are "level" number and "personality" numbers.
LEVEL_MULTIPATH is the level number for multipath.
MULTIPATH is the personality number for multipath.

In one place, we compare the level with a personality
.... bad

This makes it impossible to assemble multipath arrays.

Signed-off-by: Neil Brown <neilb [at] cse.unsw.edu.au>

### Diffstat output
./drivers/md/md.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

diff ./drivers/md/md.c~current~ ./drivers/md/md.c
--- ./drivers/md/md.c~current~ 2005-02-09 11:27:25.000000000 +1100
+++ ./drivers/md/md.c 2005-02-09 14:22:16.000000000 +1100
[at] [at] -572,7 +572,7 [at] [at] static int super_90_load(mdk_rdev_t *rde
rdev->preferred_minor = sb->md_minor;
rdev->data_offset = 0;

- if (sb->level == MULTIPATH)
+ if (sb->level == LEVEL_MULTIPATH)
rdev->desc_nr = -1;
else
rdev->desc_nr = sb->this_disk.number;
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo [at] vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

NeilBrown wrote:
> In md, there are "level" number and "personality" numbers.
> LEVEL_MULTIPATH is the level number for multipath.
> MULTIPATH is the personality number for multipath.

BTW, why the two in the first place? Isn't it nice to
eliminate one of them?

/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo [at] vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

On Thursday February 10, mjt [at] tls.msk.ru wrote:
> NeilBrown wrote:
> > In md, there are "level" number and "personality" numbers.
> > LEVEL_MULTIPATH is the level number for multipath.
> > MULTIPATH is the personality number for multipath.
>
> BTW, why the two in the first place? Isn't it nice to
> eliminate one of them?

Historical reasons....

The "Level" number corresponds to the common names of the raid levels:
0, 1, 4, 5, 6 ...
There is also "-1" for "linear", which is a bit of a hack.

The personality numbers are dense small integers: 0 1 2 3 4 ...
and are used for indexing.

You are right: the personality number isn't needed and could be
eliminated, however it isn't a priority for me yet. Patches welcome
.....

NeilBrown


-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo [at] vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html